fix: make sure GitHub's secondary rate limit is not reached #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure there is always 1 second between requests https://docs.github.com/en/rest/guides/best-practices-for-integrators#dealing-with-secondary-rate-limits
lindell
commented
Oct 28, 2021
| } | ||
|
|
||
| func (g *Github) modUnlock() { | ||
| g.lastModRequest = time.Now() |
There was a problem hiding this comment.
There are two options on where to put this. Either it's put here, making sure, as there is 1 second in between each request.
The other option is to put it in the lock, which would ensure that we never make more than X requests in X seconds.
There was a problem hiding this comment.
Either option seems sane, giving the one second delay.
This issue has stopped me from rolling out changes across a bulk set of repos.
There was a problem hiding this comment.
Let's go with the safe option, since that is what the Github docs states
wait at least one second between each request.
|
Included in release v0.36.1 🎉 |
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there is always 1 second between requests
https://docs.github.com/en/rest/guides/best-practices-for-integrators#dealing-with-secondary-rate-limits