Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry when encounting the GitHub rate limit #280

Merged
merged 8 commits into from
Oct 6, 2022
Merged

Conversation

lindell
Copy link
Owner

@lindell lindell commented Sep 20, 2022

What does this change

Adding retry mechanism to GitHub when doing changing API requests

What issue does it fix

Closes #276

@alvarofpp
Copy link

I think that delay is better than retry, like delay: 1 # one second would avoid hitting GitHub's rate limit.

@lindell
Copy link
Owner Author

lindell commented Oct 6, 2022

@alvarofpp This is already done. This is to fix large number of prs created that also causes the secondary rate limit to be hit.

func (g *Github) modLock() {

@lindell lindell merged commit 008a26a into master Oct 6, 2022
@lindell lindell deleted the retry-tmp branch October 6, 2022 19:33
@github-actions
Copy link
Contributor

Included in release v0.42.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You have exceeded a secondary rate limit
2 participants