fix: modify wasm grpc query api path. #453
Merged
+206
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/v0.45.x #453 +/- ##
==================================================
Coverage ? 55.72%
==================================================
Files ? 719
Lines ? 73921
Branches ? 0
==================================================
Hits ? 41195
Misses ? 29613
Partials ? 3113 |
brew0722
approved these changes
Mar 7, 2022
shiki-tak
approved these changes
Mar 7, 2022
shiki-tak
reviewed
Mar 7, 2022
|
|
||
| It is less efficient than using key. Only one of offset or key | ||
| should | ||
|
|
There was a problem hiding this comment.
nit: Unnecessary line breaks in a sentence?
There was a problem hiding this comment.
swagger.yaml file is generated by make proto-swagger-gen.
So, we don't need to modify swagger file.
| description: >- | ||
| count_total is set to true to indicate that the result set should | ||
| include | ||
|
|
|
|
||
| count_total is only respected when offset is used. It is ignored | ||
| when key | ||
|
|
loloicci
approved these changes
Mar 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify wasm grpc query api path.
/line/wasm/v1/contract/{address}->/lbm/wasm/v1/contract/{address}/line/wasm/v1/contract/{address}/history->/lbm/wasm/v1/code/{address}/history/line/wasm/v1/code/{code_id}/contracts->/lbm/wasm/v1/code/{code_id}/contracts/line/wasm/v1/contract/{address}/state->/lbm/wasm/v1/contract/{address}/state/wasm/v1/contract/{address}/raw/{query_data}->/lbm/wasm/v1/contract/{address}/raw/{query_data}/wasm/v1/contract/{address}/smart/{query_data}->/lbm/wasm/v1/contract/{address}/smart/{query_data}/line/wasm/v1/code/{code_id}->/lbm/wasm/v1/code/{code_id}/line/wasm/v1/code->/lbm/wasm/v1/codeMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml