Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless DenomMetadata key function #716

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented Oct 16, 2022

Make DenomMetadata substore only with DenomMetadataPrefix

Description

closes: #714

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Make DenomMetadata substore only with DenomMetadataPrefix
@tkxkd0159 tkxkd0159 self-assigned this Oct 16, 2022
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #716 (6b88faa) into main (00ab960) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   61.89%   61.91%   +0.02%     
==========================================
  Files         874      874              
  Lines       98638    98638              
==========================================
+ Hits        61048    61068      +20     
+ Misses      33966    33938      -28     
- Partials     3624     3632       +8     
Impacted Files Coverage Δ
x/bank/keeper/keeper.go 73.37% <100.00%> (ø)
x/wasm/keeper/keeper.go 85.80% <0.00%> (-0.37%) ⬇️
x/collection/msgs.go 37.03% <0.00%> (+0.37%) ⬆️
x/token/msgs.go 39.08% <0.00%> (+10.65%) ⬆️

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog.

x/bank/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Contributor

@loin3 loin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in https://github.com/cosmos/cosmos-sdk/pull/9890/files x/bank/migrations/v043/keys.go does not reflected here.
I'm not sure about this, is it okay not reflect this?

@tkxkd0159
Copy link
Member Author

tkxkd0159 commented Oct 17, 2022

Changes in https://github.com/cosmos/cosmos-sdk/pull/9890/files x/bank/migrations/v043/keys.go does not reflected here. I'm not sure about this, is it okay not reflect this?

yeah, it's legacy migration. So we don't need it (I think we need it only when we want to migrate with Upgrade without any initialize new genesis)

@tkxkd0159 tkxkd0159 requested a review from loin3 October 17, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant Denom in DenomMetadata key
4 participants