-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove useless DenomMetadata key function #716
Conversation
Make DenomMetadata substore only with DenomMetadataPrefix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 61.89% 61.91% +0.02%
==========================================
Files 874 874
Lines 98638 98638
==========================================
+ Hits 61048 61068 +20
+ Misses 33966 33938 -28
- Partials 3624 3632 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in https://github.com/cosmos/cosmos-sdk/pull/9890/files x/bank/migrations/v043/keys.go does not reflected here.
I'm not sure about this, is it okay not reflect this?
yeah, it's legacy migration. So we don't need it (I think we need it only when we want to migrate with Upgrade without any initialize new genesis) |
Make DenomMetadata substore only with DenomMetadataPrefix
Description
closes: #714
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml