Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in val_state_change.go #728

Merged
merged 9 commits into from
Oct 18, 2022

Conversation

loin3
Copy link
Contributor

@loin3 loin3 commented Oct 18, 2022

Description

typo error fixed in x/staking/keeper/va_state_change.go UnbondingToUnbonded function sanity check error message. This PR changed error message from bad state transition unbondingToBonded to bad state transition unbondingToUnbonded because function name is UnbondingToUnbonded.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@loin3 loin3 requested review from 0Tech, dudong2, tkxkd0159 and zemyblue and removed request for 0Tech October 18, 2022 05:08
@loin3 loin3 self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #728 (1a6cfed) into main (15168bf) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   61.98%   61.96%   -0.03%     
==========================================
  Files         874      874              
  Lines       98608    98614       +6     
==========================================
- Hits        61127    61108      -19     
- Misses      33869    33907      +38     
+ Partials     3612     3599      -13     
Impacted Files Coverage Δ
x/staking/keeper/val_state_change.go 59.09% <100.00%> (+0.75%) ⬆️
x/collection/msgs.go 33.88% <0.00%> (-5.00%) ⬇️
x/token/validation.go 87.27% <0.00%> (-3.64%) ⬇️
x/collection/collection.go 78.57% <0.00%> (-1.79%) ⬇️
x/wasm/keeper/keeper.go 85.80% <0.00%> (-0.37%) ⬇️
baseapp/params.go 100.00% <0.00%> (ø)
x/token/msgs.go 34.51% <0.00%> (+4.06%) ⬆️

@loin3 loin3 merged commit 5ed82db into Finschia:main Oct 18, 2022
@loin3 loin3 deleted the fix/typo-in-unbonding-to-unbonded branch October 18, 2022 08:00
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants