Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add verification on accounts into x/foundation Grants cli #732

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 18, 2022

Description

This patch will add the verification on grantee in the cli for x/foundation Query/Grants.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Oct 18, 2022
@0Tech 0Tech self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #732 (794e211) into main (d4635de) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 794e211 differs from pull request most recent head 4cb0957. Consider uploading reports for the commit 4cb0957 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   61.90%   61.95%   +0.05%     
==========================================
  Files         877      877              
  Lines       98764    98811      +47     
==========================================
+ Hits        61135    61221      +86     
+ Misses      34026    33985      -41     
- Partials     3603     3605       +2     
Impacted Files Coverage Δ
x/foundation/client/testutil/query.go 100.00% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/wasm/keeper/keeper.go 86.16% <0.00%> (+0.36%) ⬆️
x/collection/msgs.go 38.14% <0.00%> (+3.70%) ⬆️
x/token/msgs.go 34.51% <0.00%> (+4.06%) ⬆️
x/token/validation.go 87.27% <0.00%> (+16.36%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 18, 2022 08:05
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit c854241 into Finschia:main Oct 19, 2022
@0Tech 0Tech deleted the foundation_cli branch October 19, 2022 02:51
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants