Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add govmint to x/foundation specification #748

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 24, 2022

Description

Added govmint to x/foundation specification doc.
closes: #739

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added documentation Improvements or additions to documentation C:x/foundation x/foundation module labels Oct 24, 2022
@dudong2 dudong2 self-assigned this Oct 24, 2022
@0Tech 0Tech self-requested a review October 25, 2022 02:20
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a brief description about the minting feature into the concept section?

x/foundation/README.md Show resolved Hide resolved
x/foundation/README.md Outdated Show resolved Hide resolved
x/foundation/README.md Outdated Show resolved Hide resolved
x/foundation/README.md Outdated Show resolved Hide resolved
@dudong2 dudong2 merged commit d0bc22b into Finschia:main Oct 26, 2022
@dudong2 dudong2 deleted the dudong2/docs/update-foundation-docs branch October 26, 2022 02:58
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a description about GovMint into x/foundation spec
4 participants