Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get seq number for non-multisig signing #754

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 25, 2022

Description

Get sequence number for non-multisig signing in batch-sign

closes: #755

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #754 (562ff8b) into main (eb1b5e2) will decrease coverage by 0.00%.
The diff coverage is 66.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
- Coverage   62.15%   62.15%   -0.01%     
==========================================
  Files         879      879              
  Lines       99385    99438      +53     
==========================================
+ Hits        61772    61804      +32     
- Misses      33996    34015      +19     
- Partials     3617     3619       +2     
Impacted Files Coverage Δ
x/auth/client/cli/tx_sign.go 0.00% <0.00%> (ø)
x/auth/client/testutil/suite.go 96.81% <100.00%> (+0.08%) ⬆️
x/collection/msgs.go 50.00% <0.00%> (-1.64%) ⬇️
x/token/msgs.go 50.95% <0.00%> (-0.39%) ⬇️
x/wasm/keeper/keeper.go 86.16% <0.00%> (-0.37%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️
x/token/validation.go 90.90% <0.00%> (+20.00%) ⬆️

@dudong2 dudong2 self-assigned this Oct 25, 2022
@dudong2 dudong2 added the A: bug Something isn't working label Oct 25, 2022
x/auth/client/testutil/suite.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech self-requested a review October 26, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get sequence number for non multisig signing
3 participants