Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix case of gov_mint_left_count in x/foundation #790

Merged
merged 4 commits into from
Nov 11, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Nov 9, 2022

Description

This patch would fix the case of gov_mint_left_count.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: bug Something isn't working C:x/foundation x/foundation module labels Nov 9, 2022
@0Tech 0Tech self-assigned this Nov 9, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #790 (d9aed4e) into rc9/v0.46.0 (b845d33) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc9/v0.46.0     #790      +/-   ##
===============================================
- Coverage        62.19%   62.16%   -0.04%     
===============================================
  Files              880      880              
  Lines            99488    99488              
===============================================
- Hits             61874    61842      -32     
- Misses           33992    34024      +32     
  Partials          3622     3622              
Impacted Files Coverage Δ
x/collection/msgs.go 47.76% <0.00%> (-5.06%) ⬇️
x/wasm/keeper/keeper.go 86.16% <0.00%> (-0.37%) ⬇️
x/token/msgs.go 55.51% <0.00%> (+1.52%) ⬆️
x/token/validation.go 94.54% <0.00%> (+1.81%) ⬆️

@0Tech 0Tech marked this pull request as ready for review November 9, 2022 07:26
CHANGELOG.md Outdated Show resolved Hide resolved
Apply PR feedback
@0Tech 0Tech requested a review from zemyblue November 10, 2022 01:59
@0Tech 0Tech merged commit 2357407 into Finschia:rc9/v0.46.0 Nov 11, 2022
@0Tech 0Tech deleted the foundation_fix branch November 11, 2022 03:49
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants