Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libsodium test on Github Actions #327

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Add libsodium test on Github Actions #327

merged 1 commit into from
Oct 12, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Oct 11, 2021

Description

Coverage test with libsodium of build tag

@tnasu tnasu changed the title Add libsodium test on Github Actiions Add libsodium test on Github Actions Oct 11, 2021
@tnasu tnasu requested review from torao and Kynea0b October 11, 2021 05:30
@tnasu tnasu self-assigned this Oct 11, 2021
@tnasu tnasu marked this pull request as draft October 11, 2021 05:34
@tnasu tnasu force-pushed the main-default-libsodium branch 7 times, most recently from edaf5f7 to 24ac399 Compare October 11, 2021 12:25
@codecov
Copy link

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #327 (ae76e33) into main (d86ec62) will increase coverage by 0.05%.
The diff coverage is 78.78%.

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   62.88%   62.93%   +0.05%     
==========================================
  Files         272      272              
  Lines       30167    30214      +47     
==========================================
+ Hits        18971    19016      +45     
+ Misses       9474     9473       -1     
- Partials     1722     1725       +3
Impacted Files Coverage Δ
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
state/execution.go 68.09% <ø> (+1.07%) ⬆️
light/client.go 60.37% <66.66%> (-0.09%) ⬇️
light/verifier.go 69.36% <76.47%> (+1.51%) ⬆️
types/evidence.go 59.53% <85.71%> (+1.14%) ⬆️
types/protobuf.go 81.25% <100.00%> (+0.29%) ⬆️
libs/events/events.go 93.20% <0.00%> (-4.86%) ⬇️
p2p/test_util.go 64.02% <0.00%> (-2.44%) ⬇️
crypto/bls/bls.go 48.41% <0.00%> (-2.39%) ⬇️
mempool/clist_mempool.go 84.09% <0.00%> (-1.70%) ⬇️
... and 16 more

@tnasu tnasu requested review from torao and Kynea0b October 12, 2021 03:29
@tnasu tnasu marked this pull request as ready for review October 12, 2021 03:29
torao
torao approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kynea0b
Kynea0b approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torao torao added the C: test Classification: Add test case label Oct 12, 2021
@torao torao merged commit c4d40bc into Finschia:main Oct 12, 2021
tnasu added a commit that referenced this pull request Oct 13, 2021
@tnasu
Add libsodium test on Github Actions (#327)
1126144
iproudhon pushed a commit to iproudhon/ostracon that referenced this pull request Nov 3, 2021
@tnasu @iproudhon
Add libsodium test on Github Actions (Finschia#327)
40d78bf
@tnasu tnasu deleted the main-default-libsodium branch November 11, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: test Classification: Add test case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b