Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve composite key Bytes/FromBytes and make tools #335

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Improve composite key Bytes/FromBytes and make tools #335

merged 6 commits into from
Nov 1, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Oct 13, 2021

Description

  • Improve composite.PrivKey.Bytes and composite.PubKey.Bytes
  • Add composite.PrivKeyFromBytes and composite.PubKeyFromBytes
  • Make tools for MakeValSetChangeTx

@tnasu tnasu force-pushed the main-fix-composite branch 2 times, most recently from 3e399f9 to 88c7791 Compare October 13, 2021 09:42
@tnasu tnasu marked this pull request as draft October 13, 2021 10:29
@tnasu tnasu force-pushed the main-fix-composite branch 3 times, most recently from e16633a to d002824 Compare October 15, 2021 10:40
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #335 (324856b) into main (624b74c) will increase coverage by 0.06%.
The diff coverage is 80.68%.

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   62.88%   62.95%   +0.06%     
==========================================
  Files         272      272              
  Lines       30193    30259      +66     
==========================================
+ Hits        18988    19050      +62     
  Misses       9477     9477              
- Partials     1728     1732       +4
Impacted Files Coverage Δ
crypto/bls/bls.go 48.41% <0.00%> (-2.39%) ⬇️
crypto/vrf/vrf_r2ishiguro.go 100.00% <ø> (ø)
types/block.go 75.56% <50.00%> (-0.17%) ⬇️
crypto/encoding/codec.go 61.53% <66.66%> (+1.01%) ⬆️
abci/example/kvstore/persistent_kvstore.go 49.41% <73.68%> (+7.28%) ⬆️
crypto/composite/composite.go 86.66% <81.81%> (+0.95%) ⬆️
state/execution.go 68.09% <91.66%> (+1.19%) ⬆️
abci/example/kvstore/helpers.go 100.00% <100.00%> (ø)
mempool/reactor.go 79.86% <0.00%> (-3.72%) ⬇️
... and 14 more

@tnasu tnasu marked this pull request as ready for review October 18, 2021 02:32
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Oct 18, 2021
@torao torao requested review from torao and Kynea0b October 19, 2021 09:15
torao
torao suggested changes Oct 20, 2021
View reviewed changes
abci/example/kvstore/tool/make_val_set_change_tx.go Outdated Show resolved Hide resolved
rpc/client/evidence_test.go Show resolved Hide resolved
Kynea0b
Kynea0b previously approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torao
torao approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torao
torao approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b Kynea0b self-requested a review October 25, 2021 01:56
@tnasu tnasu merged commit be9b967 into Finschia:main Nov 1, 2021
iproudhon pushed a commit to iproudhon/ostracon that referenced this pull request Nov 3, 2021
@tnasu @iproudhon
Improve composite key Bytes/FromBytes and make tools (Finschia#335)
cd14c77 
* bls

* composite

* abci

* fix TestBroadcastEvidence_DuplicateVoteEvidence, see tendermint/tendermint#6678

* (fix) Add comments

* (fix) Use `os.UserHomeDir` and `filepath.Join`
@tnasu tnasu deleted the main-fix-composite branch November 11, 2021 03:06
torao added a commit to torao/ostracon that referenced this pull request Jan 13, 2023
@torao
fix code that may be relevant from Finschia#335 changes
4e472a1
@torao torao mentioned this pull request Jan 13, 2023
Merged
torao added a commit to torao/ostracon that referenced this pull request Jan 13, 2023
@torao
fix code that may be relevant from Finschia#335 changes
fcdaa82
torao added a commit to torao/ostracon that referenced this pull request Jan 13, 2023
@torao
fix code that may be relevant from Finschia#335 changes
b40d65b
ulbqb pushed a commit that referenced this pull request Jan 16, 2023
@torao
Remove BLS functionality from the mainstream (#541)
6010b48 
* remove BLS functionality from the mainstream

- Definition of BLS key and composite key.
- Fields and procedures related to BLS signature aggregation in struct and ProtocolBuffers.
- Identifiers used to identify the type of key.
- Size or hash value of the structure being tested.

* remove AggregatedSignature field

* fix code that may be relevant from #335 changes

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torao torao torao approved these changes

@Kynea0b Kynea0b Kynea0b approved these changes

Assignees

@tnasu tnasu

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnasu @torao @Kynea0b