Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement close request interception #1159

Closed
3 tasks done
cmyr opened this issue Aug 26, 2020 · 2 comments
Closed
3 tasks done

Implement close request interception #1159

cmyr opened this issue Aug 26, 2020 · 2 comments
Labels
help wanted has no one working on it yet missing a feature is missing on a specific platform shell/mac concerns the macOS backend shell/win concerns the Windows backend

Comments

@cmyr
Copy link
Member

cmyr commented Aug 26, 2020 •
edited by rjwittams
Loading

#1118 added the ability to intercept close requests, but this is currently only working for gtk; other backends should support this as well.

  • mac
  • windows
  • x11
@cmyr cmyr added help wanted has no one working on it yet shell/mac concerns the macOS backend shell/win concerns the Windows backend shell/x11 concerns the X11 backend labels Aug 26, 2020
@psychon psychon mentioned this issue Sep 9, 2020
Merged
@luleyleo luleyleo added missing a feature is missing on a specific platform and removed shell/x11 concerns the X11 backend labels Sep 10, 2020
@luleyleo luleyleo mentioned this issue Sep 10, 2020
Closed
@tay64 tay64 mentioned this issue Sep 16, 2020
Merged
@tay64
Copy link
Contributor

tay64 commented Sep 16, 2020

Hello,
I've created a PR that adds the Windows part (PR1238). This is the first time I'm trying to contribute here, hope I do not commit any faux pas in the process.

@rjwittams
Copy link
Collaborator

#1254 ends up fixing this on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted has no one working on it yet missing a feature is missing on a specific platform shell/mac concerns the macOS backend shell/win concerns the Windows backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjwittams @cmyr @luleyleo @tay64