Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable recommended default modules for golintci/revive #808

Open
dpippenger opened this issue Mar 21, 2024 · 0 comments
Open

Enable recommended default modules for golintci/revive #808

dpippenger opened this issue Mar 21, 2024 · 0 comments

Comments

@dpippenger
Copy link
Contributor

Golintci now contains an updated version of revive that has an updated default rule list that aligns with their recommended configuration. See mgechev/revive#799 for details.

Two of the newly recommended rules fail on the current code tree with what seem to be legitimate complaints. I disabled these rules to get the CI unblocked on go 1.21.x for this issue #806. It would probably be worthwhile to re-enable these rules and update the code to pass.

https://github.com/linkedin/Burrow/blob/master/.golangci.yml#L48
https://github.com/linkedin/Burrow/blob/master/.golangci.yml#L61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant