Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not introduce transitive dependency of mockito per README #166

Closed
chao2zhang opened this issue Jun 4, 2020 · 2 comments · Fixed by #169
Closed

Does not introduce transitive dependency of mockito per README #166

chao2zhang opened this issue Jun 4, 2020 · 2 comments · Fixed by #169
Labels

Comments

@chao2zhang
Copy link
Contributor

In the README.md, there is the following:
Note: The dependency on Mockito will be transitively included, so there's no need to specify both Mockito AND dexmaker-mockito

However, in dexmaker-mockito/build.gradle, mockito dependency is implementation, not API.
Therefore adding androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:2.25.1' does not introduce the mockito dependency transitively

@chao2zhang chao2zhang added the bug label Jun 4, 2020
@drewhannay
Copy link
Contributor

This is probably left over from before api and implementation were a thing in Gradle.

Do you think we should change the documentation or should we change the dependency to api? I probably prefer the latter.

@chao2zhang
Copy link
Contributor Author

Latter is also preferred from me because clients need to keep the dexmaker version in sync with mockito's, which is difficult for dexmaker 2.28.0 because it really depends on mocktio 2.28.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants