cache: Let services self-evict #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
commented
Mar 6, 2020
olix0r
commented
Mar 6, 2020
hawkw
reviewed
Mar 7, 2020
This change modifies the `cache` crate to remove its background task which is responsible for tracking service use and evicting idle services. Now, the cache (1) has no capacity limit and (2) evicts services from the cache when they drop their underlying service. This is accomplished by modifying the `CacheLayer` to accept a layer that is responsible for making the inner service shareable and for dropping its inner service when it should be considered defunct. This is accomplished by moving an `Arc<()>` into the inner stack and holding a `Weak<()>` reference to it in the cache module. Then, before a request is processed by the cache, it attempts to upgrade each cache entry and drops services that have dropped the inner service (holding the strong reference).
olix0r
force-pushed
the
ver/cache-and-buffer
branch
from
1c5a3c3 to
5fb6942
Compare
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 10, 2020
This release builds on changes in the prior release to ensure that balancers process updates eagerly. Cache capacity limitations have been removed; and services now fail eagerly, rather than making all requests wait for the timeout to expire. Also, a bug was fixed in the way the `LINKERD2_PROXY_LOG` env variable is parsed. --- * Introduce a backpressure-propagating buffer (linkerd/linkerd2-proxy#451) * trace: update tracing-subscriber to 0.2.3 (linkerd/linkerd2-proxy#455) * timeout: Introduce FailFast, Idle, and Probe middlewares (linkerd/linkerd2-proxy#452) * cache: Let services self-evict (linkerd/linkerd2-proxy#456)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Mar 10, 2020
This release builds on changes in the prior release to ensure that balancers process updates eagerly. Cache capacity limitations have been removed; and services now fail eagerly, rather than making all requests wait for the timeout to expire. Also, a bug was fixed in the way the `LINKERD2_PROXY_LOG` env variable is parsed. --- * Introduce a backpressure-propagating buffer (linkerd/linkerd2-proxy#451) * trace: update tracing-subscriber to 0.2.3 (linkerd/linkerd2-proxy#455) * timeout: Introduce FailFast, Idle, and Probe middlewares (linkerd/linkerd2-proxy#452) * cache: Let services self-evict (linkerd/linkerd2-proxy#456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
cachecrate to remove its background taskwhich is responsible for tracking service use and evicting idle
services.
Now, the cache (1) has no capacity limit and (2) evicts services from
the cache when they drop their underlying service.
This is accomplished by modifying the
CacheLayerto accept a layerthat is responsible for making the inner service shareable and for
dropping its inner service when it should be considered defunct. This is
accomplished by moving an
Arc<()>into the inner stack and holding aWeak<()>reference to it in the cache module. Then, before a requestis processed by the cache, it attempts to upgrade each cache entry and
drops services that have dropped the inner service (holding the strong
reference).