Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-api and tap services don't close open streams on shutdown #1564

Closed
klingerf opened this issue Aug 30, 2018 · 3 comments
Closed

public-api and tap services don't close open streams on shutdown #1564

klingerf opened this issue Aug 30, 2018 · 3 comments

Comments

@klingerf
Copy link
Contributor

This appears to be the same issue as #644, which occurred in the destination service.

When trying to shutdown the public-api service or the tap service, both will get stuck until all clients have closed all of their streaming connections. This means that these processes won't gracefully shutdown in Kubernetes if there are any ongoing streaming requests, and Kubernetes will be forced to kill them after waiting (1 minute, iirc) for them to shut down.

When the shutdown signal is received, these services should close all open streams and then shutdown gracefully as expected. See #1156 for the approach that we took to fixing this in the destination service.

@stale
Copy link

stale bot commented Nov 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 29, 2018
@wmorgan
Copy link
Member

wmorgan commented Nov 29, 2018

How important is this?

@stale stale bot removed the wontfix label Nov 29, 2018
@klingerf
Copy link
Contributor Author

I'd say it's important for all of the control plane components to shutdown gracefully, but this particular issue is only a problem when an active tap is happening, either from the web UI or the CLI. So we should fix it, but I'm not as concerned with non-graceful kills of tap requests. I also don't think it would be a huge amount of work to fix it -- would just need to start tracking all open tap streams.

@wmorgan wmorgan added the pinned label Nov 29, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants