Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Partial Templates and Defaults In Existing Helm Chart #3126

Closed
ihcsim opened this issue Jul 24, 2019 · 1 comment · Fixed by #3146
Closed

Include Partial Templates and Defaults In Existing Helm Chart #3126

ihcsim opened this issue Jul 24, 2019 · 1 comment · Fixed by #3146
Assignees
Labels

Comments

@ihcsim
Copy link
Contributor

ihcsim commented Jul 24, 2019

The current control plane's Helm chart is missing the proxy and proxy-init spec, and a default values.yaml config values file. The goal of this task is to update the existing chart to include the missing spec from a new partials chart. When this task is completed, users will be able to use helm install to install the Linkerd control plane, as if they are running linkerd install.

If possible, the existing linkerd install command should remain untouched. Changes to linkerd inject and multi-stage installation will also be deferred to another PR.

All new charts will be added to a new folder named, charts. Refer to #3099 for the targeted folder layout.

Some notes on configuration:

  • The proxy and proxy-init YAML spec will be included in the control plane chart as partials (defined in the partials chart).
  • The data of the linkerd-config config map will also be included in the control plane chart as partials (defined in the partials chart).
  • The identity issuer secret TLS certificate and key must be provided by users. If absent, installation should fail.
  • The CA trust root of the proxy injector and profile validator will be generated using Sprig's crypto package.
  • A default values.yaml config values file with sane defaults will be provided. (See cli/cmd/install.go for some hard coded defaults.)
  • For required variables, use the Sprig's defaults package to specify defaults. E.g., users won't necessarily know or care about the value of {{.Values.ControllerComponentLabel}}.
  • Etc.
@ihcsim ihcsim added priority/P0 Release Blocker area/install labels Jul 24, 2019
@ihcsim ihcsim changed the title Update Helm Chart to Include Partials Templates and Sane Defaults 2.5 Helm Support - Include Partial Templates and Sane Defaults Jul 24, 2019
@ihcsim ihcsim changed the title 2.5 Helm Support - Include Partial Templates and Sane Defaults Include Partial Templates and Sane Defaults In Existing Helm Chart Jul 24, 2019
@alpeb
Copy link
Member

alpeb commented Jul 24, 2019

The CA trust root of the proxy injector and profile validator will be generated using Sprig's crypto package.

This requires some minor refactoring of the TLS libs, so I created #3131 to track that effort.

@olix0r olix0r changed the title Include Partial Templates and Sane Defaults In Existing Helm Chart Include Partial Templates and Defaults In Existing Helm Chart Jul 24, 2019
@ihcsim ihcsim self-assigned this Jul 24, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants