Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kyverno policies #1462

Merged
merged 129 commits into from
Jun 21, 2024
Merged

feat: kyverno policies #1462

merged 129 commits into from
Jun 21, 2024

Conversation

srodenhuis
Copy link
Contributor

This MVP includes:

  • adding Kyverno as a core app with 2 deployment profiles (DevTest and Prod)
  • offer 5 policy profiles with (to start with) 25 policies
  • policies are per team
  • teams can customize policies, deactivate them or change the default action (enforce, audit)
  • admins can block teams from changing policies

@srodenhuis srodenhuis marked this pull request as draft January 10, 2024 15:09
@j-zimnowoda j-zimnowoda dismissed CasLubbers’s stale review June 21, 2024 09:16

The version numbers have been changed.

@j-zimnowoda
Copy link
Contributor

Some things I found which can be removed I think:

  • The file bin/build-gatekeeper-artifacts.sh can also be removed right?
  • In the README.md line 133 OPA/Gatekeeper... can be removed right?
  • The policies directory can also be removed right? If so the project structure in docs/development.md should be adjusted corectly.
  • The checkPolicies command in the Otomi CLI can also be removed right? This requires changes in index.ts, binzx/README.md, check-policies.ts, tests.ts
  • The file docs/policies.md should be updated or removed right?
  • In the file src/cmd/destroy.ts on line 105 gatekeeper.sh can be removed right?
  • In the file src/cmd/test.ts on line 21 if (!values?.apps.gatekeeper!.disableValidatingWebhook) await checkPolicies() can be removed right?
  • In the file tests/integration/upgrade.yaml on line 18 gatekeeper can be removed right?

Good points! We are going to perform further refactoring after this PR I merged.

@j-zimnowoda j-zimnowoda merged commit 07636a5 into main Jun 21, 2024
8 checks passed
@j-zimnowoda j-zimnowoda deleted the sr-mvp-kyverno branch June 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants