Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle version prefix in tools version increment script [TOOLS][MAJOR] #1616

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: handle version prefix in tools version increment script [TOOLS][MAJOR] #1616

merged 1 commit into from
May 28, 2024

Conversation

CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented May 28, 2024 •
edited
Loading

Script now handles the v version prefix and updates correctly.

Ani1357
Ani1357 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CasLubbers CasLubbers merged commit 5eda777 into main May 28, 2024
9 checks passed
@CasLubbers CasLubbers deleted the fix-major-version-tools branch May 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ani1357 Ani1357 Ani1357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CasLubbers @Ani1357