Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve robustness of initial install #1623

Merged
merged 13 commits into from
Jun 6, 2024
Merged

Conversation

merll
Copy link
Contributor

@merll merll commented Jun 5, 2024

This PR includes the following changes for making the installation process more robust against temporary connection issues with the Kubernetes API.

  • helm has been upgraded to the latest release. Since v3.15.0, it has a retry-mechanism to reattempt Kubernetes API requests on certain HTTP status codes or connection timeouts. This is currently hard-coded to 30 retries.
  • helmfile and the helm-diff plugin have been upgraded for ensuring compatibility, while kubectl has been upgraded for a closer match to the supported cluster version.
  • On initial install, the total amount of queries is reduced by
    • skipping validation against the OpenAPI spec of the cluster's Kubernetes API
    • bypassing helm diff and proceeding to a Helm chart install directly
    • running one helm instance at a time.
  • Also on the regular pipeline, Helm has a rate limiting of 20 queries per second applied. This is most likely only to affect read queries such as CRDs.

@merll merll changed the title feat: Improve robustness of initial install feat: improve robustness of initial install Jun 5, 2024
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
Tested it: installation works and after installation I enabled all the apps in one deploy also worked.

@merll merll merged commit 48730d9 into main Jun 6, 2024
8 checks passed
@merll merll deleted the me-install-hf-updates branch June 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants