-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: one backend obj for all apps #1640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srodenhuis
changed the title
Sr storage backup refactor
feat: Storage and backup refactor with one OBJ config
Jul 8, 2024
srodenhuis
changed the title
feat: Storage and backup refactor with one OBJ config
feat: one backend obj for all apps
Jul 8, 2024
Ani1357
reviewed
Jul 15, 2024
Ani1357
reviewed
Jul 15, 2024
Ani1357
reviewed
Jul 15, 2024
Ani1357
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the configuration of Object Storage and Backups more consistent and easier to maintain.
OBJ is now configured in the platform settings. A user can choose between disabled (no OBJ is configured), minioLocal (for PoC/dev use-cases) and Linode (using Linode OBJ service). Integrated applications like Harbor, cnpg, Loki, Tempo and Velero, consume the OBJ configuration and do not need to be configured independently.
With this PR we do not support any other OBJ service. If a user would like to use AWS S3 or Azure Blob, then the user needs to configure this using rawValues per app.
Other changes:
cluster.provider
. Now there are only 2 providers:linode
andcustom
settings.backup
sectionloki
,velero
,tempo
,harbor
andcnpg
NOTE:
There is no option in the velero chart to define an additional
env
using asecretKeyRef
. I made some changes to the chart and will submit a PR to support Linode Velero plugin in Velero Helm chart. See here for more info about the Linode Velero plugin: https://github.com/linode/velero-plugin/tree/main?tab=readme-ov-file