Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: one backend obj for all apps #1640

Merged
merged 27 commits into from
Jul 18, 2024
Merged

Conversation

srodenhuis
Copy link
Contributor

@srodenhuis srodenhuis commented Jul 8, 2024

This PR aims to make the configuration of Object Storage and Backups more consistent and easier to maintain.

OBJ is now configured in the platform settings. A user can choose between disabled (no OBJ is configured), minioLocal (for PoC/dev use-cases) and Linode (using Linode OBJ service). Integrated applications like Harbor, cnpg, Loki, Tempo and Velero, consume the OBJ configuration and do not need to be configured independently.

With this PR we do not support any other OBJ service. If a user would like to use AWS S3 or Azure Blob, then the user needs to configure this using rawValues per app.

Other changes:

  • Backup schedules for PVs of core apps have been removed
  • Velero now only support Linode cloud. Users can use rawValues to configure other infrastructure/cloud providers to create pv backups and snapshots
  • Linode is now the default cluster.provider. Now there are only 2 providers: linode and custom
  • Linode API key (needed to create volume snapshots) is added to the settings.backup section
  • All OBJ configuration in API and schema has been removed for loki, velero, tempo, harbor and cnpg

NOTE:
There is no option in the velero chart to define an additional env using a secretKeyRef. I made some changes to the chart and will submit a PR to support Linode Velero plugin in Velero Helm chart. See here for more info about the Linode Velero plugin: https://github.com/linode/velero-plugin/tree/main?tab=readme-ov-file

@srodenhuis srodenhuis marked this pull request as draft July 8, 2024 06:20
@srodenhuis srodenhuis changed the title Sr storage backup refactor feat: Storage and backup refactor with one OBJ config Jul 8, 2024
@srodenhuis srodenhuis changed the title feat: Storage and backup refactor with one OBJ config feat: one backend obj for all apps Jul 8, 2024
@srodenhuis srodenhuis marked this pull request as ready for review July 10, 2024 06:47
@linode linode deleted a comment from gitguardian bot Jul 18, 2024
@Ani1357 Ani1357 self-requested a review July 18, 2024 08:53
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srodenhuis srodenhuis merged commit b759896 into main Jul 18, 2024
7 checks passed
@srodenhuis srodenhuis deleted the sr-storage-backup-refactor branch July 18, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants