Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sni hosts #1658

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix: sni hosts #1658

merged 2 commits into from
Jul 26, 2024

Conversation

srodenhuis
Copy link
Contributor

This PR fixes the wrong * sniHosts when a CNAME is used. Using * is not supported anymore so we need to set the hosts

@srodenhuis srodenhuis requested a review from Ani1357 July 24, 2024 14:53
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Tested creating service with cname in dev cluster.

@srodenhuis srodenhuis merged commit 1642303 into main Jul 26, 2024
7 checks passed
@srodenhuis srodenhuis deleted the sr-fix-snihosts branch July 26, 2024 14:03
Ani1357 pushed a commit that referenced this pull request Sep 17, 2024
(cherry picked from commit 1642303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants