Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: argocd defaults #1663

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: argocd defaults #1663

merged 2 commits into from
Aug 1, 2024

Conversation

srodenhuis
Copy link
Contributor

ArgoCD defaults for new defaults approach

j-zimnowoda
j-zimnowoda approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the rendered manifests and I see autoscaling being set correctly.
The resources are also set accordingly to the values.
I really appreciate your findings and the implementation.

@j-zimnowoda j-zimnowoda merged commit c96cd83 into main Aug 1, 2024
7 checks passed
@j-zimnowoda j-zimnowoda deleted the sr-defaults-argocd branch August 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@merll merll Awaiting requested review from merll

@CasLubbers CasLubbers Awaiting requested review from CasLubbers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srodenhuis @j-zimnowoda