Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for Akamai EdgeDNS #1708

Merged
merged 8 commits into from
Sep 16, 2024
Merged

feat: support for Akamai EdgeDNS #1708

merged 8 commits into from
Sep 16, 2024

Conversation

merll
Copy link
Contributor

@merll merll commented Sep 9, 2024

implements APL-172

@Ani1357
Copy link
Contributor

Ani1357 commented Sep 10, 2024

Tested by using API credentials from the shared service account API client and all works as expected.
Can you also update the value-changes file?

@srodenhuis
Copy link
Contributor

It is not a good practice to change the upstream chart. I see external-dns chart has an Akamai provider. Why are the changes in the chart needed?

@merll
Copy link
Contributor Author

merll commented Sep 11, 2024

It is not a good practice to change the upstream chart. I see external-dns chart has an Akamai provider. Why are the changes in the chart needed?

The changes were not needed. It just seemed like a better practice to move some more of the API client configuration into a secret, as this is also done in the cert-manager configuration. But since these two secrets are stored separately in each namespace, there is no need to, and not worth breaking compatibility with upstream.

I have reverted these changes accordingly.

@merll
Copy link
Contributor Author

merll commented Sep 11, 2024

Tested by using API credentials from the shared service account API client and all works as expected. Can you also update the value-changes file?

What should go into the value-changes? I thought for new values this was only for setting defaults. But AFAIK there are no useful defaults to be set here, since it is all individual user input.

@Ani1357
Copy link
Contributor

Ani1357 commented Sep 12, 2024

Tested by using API credentials from the shared service account API client and all works as expected. Can you also update the value-changes file?

What should go into the value-changes? I thought for new values this was only for setting defaults. But AFAIK there are no useful defaults to be set here, since it is all individual user input.

You are right, please ignore my comment. Indeed we are only setting defaults there.

@srodenhuis
Copy link
Contributor

You should also add the provider to the API: https://github.com/linode/apl-api/blob/main/src/openapi/definitions.yaml

@merll
Copy link
Contributor Author

merll commented Sep 16, 2024

You should also add the provider to the API: https://github.com/linode/apl-api/blob/main/src/openapi/definitions.yaml

Done: linode/apl-api#559

@merll merll merged commit 12c11dd into main Sep 16, 2024
7 checks passed
@merll merll deleted the mer-akamai-dns branch September 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants