-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for Akamai EdgeDNS #1708
Conversation
Tested by using API credentials from the shared service account API client and all works as expected. |
It is not a good practice to change the upstream chart. I see external-dns chart has an Akamai provider. Why are the changes in the chart needed? |
The changes were not needed. It just seemed like a better practice to move some more of the API client configuration into a secret, as this is also done in the I have reverted these changes accordingly. |
What should go into the value-changes? I thought for new values this was only for setting defaults. But AFAIK there are no useful defaults to be set here, since it is all individual user input. |
You are right, please ignore my comment. Indeed we are only setting defaults there. |
You should also add the provider to the API: https://github.com/linode/apl-api/blob/main/src/openapi/definitions.yaml |
Done: linode/apl-api#559 |
implements APL-172