Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rm private ingress #1712

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: rm private ingress #1712

merged 3 commits into from
Sep 13, 2024

Conversation

srodenhuis
Copy link
Contributor

Remove private ingress class option (which was Azure specific)

Ani1357
Ani1357 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by deploying from branch sr-rm-private-ingress(apl-core and apl-api):

  • Private ingress option is gone: ✅
  • Annotations can be applied to LB svc as expected: ✅

@srodenhuis srodenhuis merged commit 1d475d3 into main Sep 13, 2024
7 checks passed
@srodenhuis srodenhuis deleted the sr-rm-private-ingress branch September 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ani1357 Ani1357 Ani1357 approved these changes

@ferruhcihan ferruhcihan Awaiting requested review from ferruhcihan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srodenhuis @Ani1357