Remove GroundValueConstraint and GroundLinearConstraint

[eriq-augustine]

Issue by eriq-augustine
Thursday Nov 15, 2018 at 14:28 GMT
Originally opened as eriq-augustine#185

---

Both of these are just arithmetic rules.
GroundValueConstraint is just RVA = val.
GroundLinearConstraint is just coeff * RVA + coeff * RVA ... <=|=|>= val.

I think the constraint blocker is the only thing that uses them.
We will have to be a bit careful on the semantics:

• This would be a ground rule without an associated rule (unless we create a dummy).
• There are both special cases of arithmetic rules.

Maybe instead of removal, we can just treat them as special cases (subclasses).