Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and Possibly Rework getAtom() #243

Open
eriq-augustine opened this issue Oct 30, 2019 · 2 comments
Open

Review and Possibly Rework getAtom() #243

eriq-augustine opened this issue Oct 30, 2019 · 2 comments
Labels
Components - Database Difficulty - Hard Priority - Normal Type - Investigation Type - Refactor

Comments

@eriq-augustine
Copy link
Member

Issue by eriq-augustine
Tuesday Feb 19, 2019 at 03:27 GMT
Originally opened as eriq-augustine#196

Enough has changed since this abstraction was first implemented, that it is worth going back to review and possibly change the entire architecture:

  • Atom Caches
  • Fetching Atoms (DB and cache)
  • Atom Managers
  • Databases (particularly how databases own atom caches, perhaps they should just be given one)
@eriq-augustine
Copy link
Member Author

Comment by eriq-augustine
Tuesday Feb 19, 2019 at 03:28 GMT

Also, review the thread-safety of the entire atom stack.

@eriq-augustine
Copy link
Member Author

Comment by eriq-augustine
Tuesday Feb 19, 2019 at 03:29 GMT

Bumping to hard because of the performance concerns involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components - Database Difficulty - Hard Priority - Normal Type - Investigation Type - Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eriq-augustine