Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gitweb): correct parsing remote url! #154

Merged
merged 4 commits into from
Nov 26, 2023

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 26, 2023

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink to copy git link.
  • Use GitLink! to open git link in browser.
  • Use GitLink blame to copy the /blame git link.
  • Use GitLink! blame to open the /blame git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@github-actions github-actions bot added the perf label Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8530e1a) 76.34% compared to head (44bdd9f) 78.10%.

Files Patch % Lines
lua/gitlinker/linker.lua 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   76.34%   78.10%   +1.75%     
==========================================
  Files          11       11              
  Lines         964      950      -14     
==========================================
+ Hits          736      742       +6     
+ Misses        228      208      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit 382b31e into master Nov 26, 2023
8 checks passed
@linrongbin16 linrongbin16 deleted the perf-parse-gitweb-correct branch November 26, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant