-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): fix ci pipeline errors #184
Conversation
Fix unit test breaks from #183, relate: #181 hi @lopi-py , would you please tell me, how should I execute the The unit tests in CI are failed: https://github.com/linrongbin16/gitlinker.nvim/actions/runs/7395276412/job/20118132290 Do I need to invoke I don't understand, why
I think I understand how it works, to fix the test, I will split those functions and invoke them in vusted. Or we could use other async libraries: I found they are also feature rich, single file (easy to embed), and popular. |
Its failing because you are running an async function in a non async function. I'm not sure how to handle it. I tried waiting on a non async context but I get attemp to cross C-bounady error. You could wrap it like this async.run(function()
-- run the actual test.
end) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 73.40% 68.63% -4.77%
==========================================
Files 7 7
Lines 786 794 +8
==========================================
- Hits 577 545 -32
- Misses 209 249 +40 ☔ View full report in Codecov by Sentry. |
Thank you! it works! |
Regression Test
Platforms
Hosts
Functions
GitLink
to copy git link.GitLink!
to open git link in browser.GitLink blame
to copy the/blame
git link.GitLink! blame
to open the/blame
git link in browser.