Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix undefined reference errors on spdlog 1.14.0 #412

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: fix undefined reference errors on spdlog 1.14.0 #412

merged 1 commit into from
Apr 29, 2024

Conversation

hillwoodroc
Copy link
Contributor

@hillwoodroc hillwoodroc commented Apr 28, 2024 •
edited
Loading

Support spdlog 1.14.0

Log: spdlog 1.14.0 added string view overloads for logger accessor. We should include more headers for this change in dtkcore.

@hillwoodroc
fix: fix undefined reference errors on spdlog 1.14.0
71392fc 
Support spdlog 1.14.0

Log: spdlog 1.14.0 add string view overloads for logger accessor. We should include
more headers for this change in dtkcore.
@deepin-ci-robot
Copy link
Contributor

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Apr 28, 2024
@deepin-ci-robot
sync: from linuxdeepin/dtkcore
f9154c7 
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#412
@deepin-ci-robot deepin-ci-robot mentioned this pull request Apr 28, 2024
Merged
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 28, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@BLumia BLumia requested a review from asterwyx April 28, 2024 09:24
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 45e8e60 into linuxdeepin:master Apr 29, 2024
19 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6core that referenced this pull request Apr 29, 2024
@deepin-ci-robot @18202781743
sync: from linuxdeepin/dtkcore
2add604 
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegechen kegechen kegechen approved these changes

@asterwyx asterwyx Awaiting requested review from asterwyx

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hillwoodroc @deepin-ci-robot @kegechen