Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DConfigFile is invalid when AppId is empty #417

Merged
merged 1 commit into from
May 14, 2024

Conversation

18202781743
Copy link
Contributor

Empty is used in dde-dconfig-daemon, and it is valid.

Empty is used in dde-dconfig-daemon, and it is valid.
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request May 14, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#417
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • isValidAppId 函数中的正则表达式可能不匹配预期的格式,因为 ' ' 不是合法的字符。
  • isValidAppId 函数中的正则表达式重复了,可以在文件头定义一个常量来复用。
  • ut_DConfigFileCheckAppId 测试用例中新增了 NoAppId,但未提供该值的定义或注释说明。
  • ut_DConfigFileCheckAppId 测试用例中的 std::tuple 使用了 truefalse 而不是 Qt::CheckedQt::Unchecked,这可能会导致理解上的混淆。

是否建议立即修改:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 861a35a into linuxdeepin:master May 14, 2024
18 of 21 checks passed
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 14, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

kegechen pushed a commit to linuxdeepin/dtk6core that referenced this pull request May 14, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants