Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pidfd leak #449

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: pidfd leak #449

merged 1 commit into from
Dec 10, 2024

Conversation

18202781743
Copy link
Contributor

pidfd must be closed by caller according QDBusUnixFileDescriptor.

pms: BUG-293049

pidfd must be closed by caller according QDBusUnixFileDescriptor.

pms: BUG-293049
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • getId函数中增加了对pid的输出,有助于调试和问题追踪。
  • 在调用QDBusUnixFileDescriptor后立即关闭了pidfd,这是一个好的做法,确保资源不被泄露。

是否建议立即修改:

  • 否,提交的代码没有明显的语法或逻辑错误。
  • 是,建议添加对pidfd关闭操作的错误处理,以防close函数调用失败时程序无法正常处理。
  • 是,建议在关闭pidfd之前添加注释说明,解释为什么需要关闭这个文件描述符。

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Dec 9, 2024
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#449
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ComixHe, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 53be287 into linuxdeepin:master Dec 10, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants