fix(config): do not cache tile sets forever as they can be updated #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a issue where a database update is applied but some lambdas will hold onto the old config until they get restarted
| @@ -110,7 +110,7 @@ async function useLocal(): Promise<void> { | |||
| const requestId = ulid.ulid(); | |||
| const logger = LogConfig.get().child({ id: requestId }); | |||
|
|
|||
| const tileSets = await Promise.all([...TileSets.cache.values()]); | |||
| const tileSets = await Promise.all([...TileSets.cache.values()].map((c) => c.value)); | |||
There was a problem hiding this comment.
Is this change for Cloning the TileSets values?
There was a problem hiding this comment.
this change is because we now store the time of when we fetched the object last.
so the [....cache.values()] has gone form TileSet[] to
{ value: TileSet, time: number}[]
Wentao-Kuang
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a issue where a database update is applied but some lambdas will hold onto the old config until they get restarted