feat(lambda-tiler): Increase limit of total file size. #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
May 18, 2022
| if (searchKey.endsWith('.tif') || searchKey.endsWith('.tiff')) files.push(key); | ||
| let totalSize = 0; | ||
| for await (const key of fsa.details(path)) { | ||
| console.log(key); |
blacha
reviewed
May 18, 2022
| @@ -9,6 +9,9 @@ import { CogJobFactory } from '@basemaps/cli'; | |||
| import * as ulid from 'ulid'; | |||
| import { basename } from 'path'; | |||
|
|
|||
| const FILES_NUMBER_LIMIT = 10_000; // Limit to 10000 files | |||
blacha
reviewed
May 18, 2022
| @@ -120,7 +120,7 @@ o.spec('Import', () => { | |||
| o('should return 200 with existing import', async () => { | |||
There was a problem hiding this comment.
would be good to have a test for the file count and file size limits
There was a problem hiding this comment.
All fixed. Can you please have a look? Thanks.
blacha
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.