feat(config-cli): new command tool to bundle config json from a config path #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Jun 15, 2022
packages/config-cli/README.md
Outdated
| Bundle config files into config bundle json from a given config path. | ||
|
|
||
| ```bash | ||
| ./bin/bmc.js screenshot --config config/ --bundle config/config.json |
There was a problem hiding this comment.
bundle ?
bundling into the output directory could be interesting, maybe make the recommendation just --output config.json ?
blacha
previously approved these changes
Jun 15, 2022
blacha
changed the title
blacha
reviewed
Jun 15, 2022
| host = `http://localhost:${port}`; | ||
| BasemapsServer = await startServer(host, port, config, logger); | ||
| // Force a default url base so WMTS requests know their relative url | ||
| process.env[Env.PublicUrlBase] = host; |
There was a problem hiding this comment.
if this is set we need to respect it we should not be overwriting env vars.
There was a problem hiding this comment.
We can set this back after the script running in finally.
There was a problem hiding this comment.
Proab safer to just use it if it exists the same as basemaps-server cli
There was a problem hiding this comment.
Cool, updated.
blacha
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.