feat(cli): New cli to bundle the assets into cotar file. #2311
Conversation
| files.sort((a, b) => a.localeCompare(b)); | ||
| logger.info({ output: outputTar, files: files.length }, 'Tar:Create'); | ||
|
|
||
| for (const file of files) await tarBuilder.write(file, await fsa.read(file)); |
There was a problem hiding this comment.
this file name might need to be shortened, what does the tar archive look like?
There was a problem hiding this comment.
Yes, do we need to be short as assets/fonts/... or just fonts/...?
There was a problem hiding this comment.
Updated. By doing this. We also can move the fonts.json to root directory in cotar file.
There was a problem hiding this comment.
I think just leave the json file as is, and we can just update the server to point at the right spot?
There was a problem hiding this comment.
It was in fonts/fonts.json after build. Then we move it to fonts.json in the cotar. Shall we still keep it in the fonts/font.json?
There was a problem hiding this comment.
yeah this bundling logic should replicate the excat file system we should change it in the filesystem if we want it changed!
|
This pull request introduces 1 alert when merging fd9efcc into 8be654c - view on LGTM.com new alerts:
|
No description provided.