feat(cli): Create-overview determine max zoom overview from the gsd #2612
Conversation
| logger.info({ source, duration: st.tick() }, 'CreateOverview:ListTiffs:Done'); | ||
|
|
||
| logger.debug({ source }, 'CreateOverview:PrepareSourceFiles'); | ||
| const tileMatrix = await this.getTileMatrix(tiffSource); | ||
| const tiff = await CogTiff.create(tiffSource[0]); |
There was a problem hiding this comment.
this will throw if there are not tiffs, maybe check and exit?
There was a problem hiding this comment.
We have a filterTiff for the file lists. So I am ok if the script just die here if the not tiff?
There was a problem hiding this comment.
we should let it die here, but with a nice error message, stack traces are not super helpful to users
| @@ -18,6 +18,7 @@ import { JobTiles, tile } from './tile.generator.js'; | |||
| import { SimpleTimer } from './timer.js'; | |||
|
|
|||
| const DefaultMaxZoom = 15; | |||
| const MaxNumberTiles = 250000; | |||
There was a problem hiding this comment.
could we add a sentence explaining what these numbers do?
| @@ -115,6 +114,7 @@ export class CommandCreateOverview extends CommandLineAction { | |||
| qk = QuadKey.parent(qk); | |||
| } | |||
| } | |||
| if (tiles.size > MaxNumberTiles) this.prepareTiles(files, maxZoom - 1); | |||
| @@ -126,8 +126,7 @@ export class CommandCreateOverview extends CommandLineAction { | |||
| } | |||
| } | |||
|
|
|||
| async getTileMatrix(sources: ChunkSource[]): Promise<TileMatrixSet> { | |||
| const tiff = await CogTiff.create(sources[0]); | |||
| async getTileMatrix(tiff: CogTiff): Promise<TileMatrixSet> { | |||
There was a problem hiding this comment.
this doesnt need to be async the tiff is tiff.init(true) before.
(you are initing the tiff twice)
There was a problem hiding this comment.
I need this to run await tiff.getImage(0).loadGeoTiffTags();, before getting the espg. The just tiff.init now working.
There was a problem hiding this comment.
The tiff.init(true) is called in the other function you should pull that out to the same place as the new CogTiff
No description provided.