feat(lambda-tiler): Update the wmts resource url to include the daterange. #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Feb 7, 2023
| const resourceURLs = lines.filter((f) => f.includes('<ResourceURL')).map((f) => f.trim()); | ||
| o(resourceURLs).deepEquals([ | ||
| '<ResourceURL format="image/png" resourceType="tile" template="https://tiles.test/v1/tiles/aerial/{TileMatrixSet}/{TileMatrix}/{TileCol}/{TileRow}.png?api=d01f7w7rnhdzg0p7fyrc9v9ard1&config=Q5pC4UjWdtFLU1CYtLcRSmB49RekgDgMa5EGJnB2M&date%5Bbefore%5D=2021" />', | ||
| '<ResourceURL format="image/png" resourceType="tile" template="https://tiles.test/v1/tiles/ōtorohanga-urban-2021-0.1m/{TileMatrixSet}/{TileMatrix}/{TileCol}/{TileRow}.png?api=d01f7w7rnhdzg0p7fyrc9v9ard1&config=Q5pC4UjWdtFLU1CYtLcRSmB49RekgDgMa5EGJnB2M&date%5Bbefore%5D=2021" />', |
There was a problem hiding this comment.
We shouldn't use a date range on a individual imagery set.
There was a problem hiding this comment.
I see, I just think this ResourceURL is missing the daterange parameter so I made this change. I think WMTS already contain the filteredLayers, then we don't need this changes. The PR could be closed.
blacha
reviewed
Feb 7, 2023
| @@ -38,6 +38,8 @@ export interface WmtsCapabilitiesParams { | |||
| config?: string | null; | |||
| /** Specific layers to add to the WMTS */ | |||
| layers?: ConfigLayer[] | null; | |||
| /** Specific DateRange for the wmts layers */ | |||
| dateRange?: Record<string, string | undefined>; | |||
There was a problem hiding this comment.
could this just be filters? so it could be expanded later?
blacha
reviewed
Feb 8, 2023
| ].join('/'); | ||
| } | ||
|
|
||
| buildResourceUrl(tileSetId: string, suffix: string): VNodeElement { | ||
| buildResourceUrl(tileSetId: string, suffix: string, AddFilter = false): VNodeElement { |
There was a problem hiding this comment.
Good point, just fixed.
blacha
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.