feat(lambda-tiler): Refactoring the wmts Capablity to builder interface. #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Feb 13, 2023
| wmts.maxZoom = maxZoom; | ||
|
|
||
| const nodes = wmts.toVNode(); | ||
| const nodes = wmts.buildWmtsCapabilities(); |
blacha
reviewed
Feb 14, 2023
| } | ||
|
|
||
| setFormats(formats?: ImageFormat[]): void { | ||
| this.formats = formats ? formats : ImageFormatOrder; |
There was a problem hiding this comment.
the defaulting should be in the getter not the setter
| if (provider == null) return; | ||
| const { serviceIdentification, serviceProvider } = provider; | ||
| const { contact } = serviceProvider; | ||
| this.provider = [ |
There was a problem hiding this comment.
would be best to leave all the vnode stuff in toVnode() and just store the provider
| ]; | ||
| } | ||
|
|
||
| buildLayer(tileSet: ConfigTileSet): void { |
There was a problem hiding this comment.
would be best to addLayer and then leave the rendering to vNode to the end.
blacha
reviewed
Feb 22, 2023
| } | ||
|
|
||
| toXml(): string { | ||
| return '<?xml version="1.0" encoding="utf-8"?>\n' + this.toVNode().toString(); | ||
| return '<?xml version="1.0" encoding="utf-8"?>\n' + this.builder.toVNode().toString(); |
There was a problem hiding this comment.
would be great to move this into the builder too
blacha
reviewed
Feb 22, 2023
| export class WmtsCapabilities { | ||
| builder: WmtsCapabilitiesBuilder; | ||
|
|
||
| constructor(builder: WmtsCapabilitiesBuilder, params: WmtsCapabilitiesParams) { |
There was a problem hiding this comment.
Delete this class, rename build to WmtsCapabilities then this function could be WmtsCabilities.fromParams(parms)
blacha
reviewed
Feb 22, 2023
| this.builder.addFormats(params.formats); | ||
|
|
||
| // Build wmts capabilities | ||
| this.builder.addTileSet(params.tileSet); |
There was a problem hiding this comment.
addX needs to be able to be called multiple times, eg
x.addFormats(ImageFormat.WebP)
x.addFormats(ImageFormat.Avif)another option there would be to support
x.addFormat(ImageFormat.WebP, ImageFormat.Avif)
x.addFormat(...params.formats)should add both webp and avif
for (const im of imagery) x.addImagery(im)
blacha
reviewed
Feb 26, 2023
blacha
previously approved these changes
Feb 26, 2023
blacha
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.