feat(cli): Update a preview url for zoom level changes. #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Feb 20, 2023
| @@ -176,7 +176,7 @@ export class CommandImport extends CommandLineAction { | |||
| let msg = ' - Zoom level updated.'; | |||
| if (layer.minZoom !== existing.minZoom) msg += ` min zoom ${existing.minZoom} -> ${layer.minZoom}`; | |||
| if (layer.maxZoom !== existing.maxZoom) msg += ` max zoom ${existing.maxZoom} -> ${layer.maxZoom}`; | |||
| change.push(`${msg}\n`); | |||
| change.push(`${msg} -- [Aerial]((${PublicUrlBase}?config=${this.config.value}&debug))\n`); | |||
There was a problem hiding this comment.
I think this url should be added to the next if statements? we are going to need both NZTM and Webmercator links?
What happens if the zoom changes and the layer id changes? going to get a bunch of links?
There was a problem hiding this comment.
Good point, we shouldn't end up with too many links. I have update this only have a default aerial preview link if only zoom level change and layer id not change.
There was a problem hiding this comment.
I add the links for both available projections now.
blacha
reviewed
Feb 21, 2023
| } | ||
| if (layer[3857] && layer[3857] !== existing[3857]) { | ||
| if (layer[3857]) { | ||
| const urls = await this.prepareUrl(layer[3857], mem, GoogleTms); |
blacha
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.