Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): multithread gdal warp in COG creation #2744

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix(cli): multithread gdal warp in COG creation #2744

merged 1 commit into from
Mar 20, 2023

Conversation

blacha
Copy link
Member

@blacha blacha commented Mar 19, 2023

@blacha blacha requested a review from a team as a code owner March 19, 2023 21:31
Wentao-Kuang
Wentao-Kuang reviewed Mar 19, 2023
View reviewed changes
packages/cli/src/gdal/gdal.cog.ts
@@ -92,6 +92,10 @@ export class GdalCogBuilder {
// Max CPU POWER
'-co',
'NUM_THREADS=ALL_CPUS',
// in GDAL 3.7.x NUM_THREADS will also set GDAL_NUM_THREADS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Do we also need to upgrade the GDAL version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when GDAL releases 3.7.x we can remove this line.

@blacha blacha added this pull request to the merge queue Mar 20, 2023
@blacha blacha merged commit 1b00735 into master Mar 20, 2023
@blacha blacha deleted the fix/multi-thread-warp branch March 20, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wentao-Kuang Wentao-Kuang Wentao-Kuang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blacha @Wentao-Kuang