Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landing): increase visual prominence of category in layer dropdown #2917

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

ajacombs
Copy link
Contributor

@ajacombs ajacombs commented Aug 25, 2023

Description

Increase the visual prominence of the category heading in the layer dropdown on the landing page. It does this by:

  • Increasing the size, from 75% layer name size to 90% layer name size.
  • Darkening the colour, from a light grey #999999 to LUI teal #00425d
  • Adding 1px of letterspacing, common typographic practice for all caps text to improve legibility.

Before:
Screenshot from 2023-08-25 15-51-58

After:
Screenshot from 2023-08-25 15-52-30

Intention

After adding the georeferenced historical imagery layers to Basemaps, there are many more layers in the dropdown than before. The category of these layers is also more important than before when searching, thus increasing the visual prominence of the category header will improve the UX when searching for a layer in the dropdown.

The method of inserting styles into the react-select Select component feels very non-ideal, but seems to be the necessary way currently to modify the styles of the dropdown. Future work to refactor the frontend should include looking at a more comprehensive approach for styling components.

PR updated with new commit which swaps to using basic CSS styles in index.css, and adding classNamePrefix and id props to the Select component to allow the CSS selectors to have consistent names to target.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in title

@ajacombs ajacombs requested a review from a team as a code owner August 25, 2023 03:54
@ajacombs ajacombs force-pushed the feat/increase-dropdown-category-prominence branch from 8703602 to d7c2730 Compare August 29, 2023 03:48
@ajacombs ajacombs added this pull request to the merge queue Aug 30, 2023
Merged via the queue into master with commit f158f57 Aug 30, 2023
10 checks passed
@ajacombs ajacombs deleted the feat/increase-dropdown-category-prominence branch August 30, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants