fix(cogify): prevent empty tiffs from being stored #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
commented
Dec 5, 2023
blacha
force-pushed
the
fix/prevent-empty-tiff
branch
from
0c1d578
to
312d130
Compare
Wentao-Kuang
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As cogify does not have the exact bounding polygon of the data inside the tiff, there are occasions where a tiff is created outside the extent of the data. this tiff is empty and gdal will create a empty sparse tiff.
These tiffs are useless and should be ignored/deleted.
Modification
Check the output tiff to see if its empty before uploading it.
Checklist
If not applicable, provide explanation of why.