fix(shared): allow reading of buckets from other regions #3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
changed the title
blacha
force-pushed
the
fix/default-index-html
branch
from
8fe3ee0
to
55269a4
Compare
Wentao-Kuang
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have buckets in multiple regions, when requesting data using the default client it will throw a 301 moved error rather than fetching the data from the bucket.
If we know the region ahead of time we should create new s3 clients for those regions to save the request -> failure -> retry flow.
Modification
Retry bucket reads when reading across region
Checklist
If not applicable, provide explanation of why.