Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(landing): ensure the layer dropdown always showing for all outputs. BM-1001 #3241

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Apr 21, 2024

Motivation

Outputs layers not showing up when using the i query parameter to viewing elevations data. Cause the Config.map.styleId will return the empty styleId.

Modification

  • Using layerId when style query parameter not specified.
  • Showing 'off' when there is no selectedSrouce for the layer dropdown.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner April 21, 2024 23:25
Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
@blacha blacha changed the title fix(landing): Fix to ensure the layer dropdown always showing for all outputs. BM-1001 fix(landing): ensure the layer dropdown always showing for all outputs. BM-1001 Apr 21, 2024
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Apr 21, 2024
Merged via the queue into master with commit 766f92b Apr 22, 2024
11 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/ensure-layer-dropdown branch April 22, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants