Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-loader): allow rgb color objects #3288

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

blacha
Copy link
Member

@blacha blacha commented Jun 17, 2024

Motivation

Allows configuration objects to use colors as {r: 255, g: 255, b:255, alpha: 255} as well as #ff00ffff

Modification

parse background colors as rgba hex strings or objects

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@blacha blacha requested a review from a team as a code owner June 17, 2024 03:52
@blacha blacha requested a review from Wentao-Kuang June 17, 2024 03:52
@blacha blacha added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 23df7de Jun 17, 2024
10 of 11 checks passed
@blacha blacha deleted the fix/allow-rgba-object-config branch June 17, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants