Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cogify): error early if no source collection.json is found BM-1047 #3296

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

blacha
Copy link
Member

@blacha blacha commented Jun 26, 2024

Motivation

When importing imagery into basemaps we know if there is a source stac collection at the first step, but we only warn that we cannot find it.

In most of our import processes not having a stac collection should be a errro

Modifications

Add --require-stac-collection to throw a error if a stac collection cannot be found when createing a cover

Verification

Added new integration test to covering creation with and without the new flag.

@blacha blacha marked this pull request as ready for review June 26, 2024 02:46
@blacha blacha requested a review from a team as a code owner June 26, 2024 02:46
@blacha blacha requested a review from Wentao-Kuang June 26, 2024 02:46
@blacha blacha changed the title feat(cogify): error early if no source collection.json is found feat(cogify): error early if no source collection.json is found BM-1047 Jun 26, 2024
@blacha blacha added this pull request to the merge queue Jun 26, 2024
Merged via the queue into master with commit aecb5e6 Jun 26, 2024
12 checks passed
@blacha blacha deleted the feat/require-stac-collection branch June 26, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants