Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): allow unprefixed query keys #3333

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

blacha
Copy link
Member

@blacha blacha commented Aug 26, 2024

Motivation

all of our unit tests use the memory config provider which ensures the keys start with the correct prefix

Modifications

In dynamodb configs force the prefix to be added if its not present.

Verification

updated unit tests

@blacha blacha marked this pull request as ready for review August 26, 2024 02:54
@blacha blacha requested a review from a team as a code owner August 26, 2024 02:54
@blacha blacha added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit 42c2279 Aug 26, 2024
11 of 12 checks passed
@blacha blacha deleted the fix/allow-unprefixed-keys branch August 26, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants