feat(landing): track with google analytics if $GOOGLE_ANALYTICS is set #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
force-pushed
the
feat/google-analytics-tracking
branch
from
b373233
to
c502e86
Compare
jacott
suggested changes
Jun 10, 2020
packages/landing/deploy.js
Outdated
Comment on lines
36
to
41
| </script> | ||
| </html>`; | ||
|
|
||
| // Put the tracking at the bottom of the index.html | ||
| const outputHtml = rawIndexHtml.toString().replace('</html>', trackingCode); | ||
| await fs.writeFile('./static/index.html', outputHtml); |
There was a problem hiding this comment.
A script tag can't go directly into an html tag
There was a problem hiding this comment.
I mean it "can" and it works in both chrome and firefox, ideally i guess it should live inside the head tag with a "defer"
…t during deployment
blacha
force-pushed
the
feat/google-analytics-tracking
branch
from
c502e86
to
e8939de
Compare
jacott
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.