fix(cli): ensure fatal errors set process exit code to 1 #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Jun 30, 2020
| * Utility error to throw expecting that Logger will fatal log its contents | ||
| */ | ||
| export class LoggerFatalError extends Error { | ||
| obj: object; |
There was a problem hiding this comment.
For some reason our linter says to use Record<string, unknown> rather than Object I dont know what a object is in terms of typing, I cant ctrl click it to goto its defs
Not too sure the reasoning. but make it a Record<>
jacott
force-pushed
the
fix/cli/process-exit-code
branch
from
167b104
to
daa6cc9
Compare
blacha
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
cogify cogwas detectingjob.jsonversion mismatch but was exiting the process with code 0 (success); now exits with code 1.